Add duplicate keyword argument error #1407
Conversation
parser/src/function.rs
Outdated
| @@ -6,9 +6,19 @@ type FunctionArgument = (Option<Option<String>>, ast::Expression); | |||
| pub fn parse_args(func_args: Vec<FunctionArgument>) -> Result<ast::ArgumentList, LexicalError> { | |||
| let mut args = vec![]; | |||
| let mut keywords = vec![]; | |||
|
|
|||
| let mut keyword_names = vec![]; | |||
There was a problem hiding this comment.
Using a set like object instead of a vector would gain a speedup for larger amounts of arguments. The contains method for Vec is likely O(n) while the contains method (or equivalent method) on set like types is O(1).
There was a problem hiding this comment.
Might be worthwhile to use <collection>::with_capacity(func_args.len()) to avoid having lots of small allocations as they get added to the collection, regardless of whether HashMap or Vec is used.
Edit: however that might use a bit more memory sometimes. Perhaps premature optimization until someone can get around to doing measurement.
There was a problem hiding this comment.
The vector re-allocation scheme is actually pretty good in rust. The amount of memory is roughly doubled, so capacity will grow something like this: 1, 2, 4, 8, 16 etc.. This results in few allocations.
|
The travis build is failing. Could you look into this? You also might want to rebase upon the master branch, since the azure build is fixed in there. |
fb316b1 to
ecf8e44
Compare
ecf8e44 to
21669a0
Compare
Fixes #116