Correctly handle a SystemExit unwound to the top level of execution #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30a6aa8 to
adfd298
Compare
youknowone
reviewed
Oct 4, 2019
| println!("{}", s); | ||
| } | ||
| }), | ||
| _ => { |
There was a problem hiding this comment.
is this arm same to print!("{}", vm.to_str(&args))?
There was a problem hiding this comment.
Yep, I think I was trying to emulate code from exceptions.rs but it's just the str of it I guess.
There was a problem hiding this comment.
Actually, it's the repr of the args tuple.
47ef145 to
f9e5c98
Compare
Int division in _sre.py, float precision printf formatting
f9e5c98 to
e304504
Compare
youknowone
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.