Skip to content

Implement delattr for type object #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2019
Merged

Implement delattr for type object #1496

merged 1 commit into from
Oct 11, 2019

Conversation

rls1004
Copy link
Contributor

@rls1004 rls1004 commented Oct 9, 2019 •
edited
Loading

Implement delattr for type object

Before

>>>>> class C:
.....   x = 10
..... 
>>>>> del C.x
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'type' object has no attribute 'x'
>>>>> C.x
10

After

>>>>> class C:
.....   x = 10
.....
>>>>> del C.x
>>>>> C.x
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: C has no attribute 'x'

Fixed: #1404

@rls1004 rls1004 force-pushed the issue1404 branch 2 times, most recently from aa07162 to 85689b4 Compare October 9, 2019 15:18
windelbouwman
windelbouwman reviewed Oct 9, 2019
View reviewed changes
tests/snippets/attr.py
del a.c
with assert_raises(AttributeError):
_ = a.c

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the snippet the from the explanation in the pull request as well? Class attributes probably take another code path as instance attributes.

I mean this snippet:

class C:
    x = 10

...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I added it.

@windelbouwman windelbouwman merged commit e5c92d6 into RustPython:master Oct 11, 2019
@rls1004 rls1004 mentioned this pull request Oct 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windelbouwman windelbouwman windelbouwman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An error occurs when deleting an attribute of a class.
2 participants
@rls1004 @windelbouwman