Skip to content

introduce and adapt vm.identical_or_equal to test is or else __eq__ #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2019
Merged

introduce and adapt vm.identical_or_equal to test is or else __eq__ #1501

merged 1 commit into from
Oct 12, 2019

Conversation

youknowone
Copy link
Member

No description provided.

@youknowone youknowone force-pushed the bool-equal branch 2 times, most recently from 4edcca2 to 0f7d349 Compare October 11, 2019 16:26
windelbouwman
windelbouwman approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@windelbouwman windelbouwman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly makes a lot of sense! Good simplification.

windelbouwman
windelbouwman reviewed Oct 12, 2019
View reviewed changes
@youknowone youknowone changed the title introduce and adapt vm.bool_equal to test is or else __eq__ introduce and adapt vm.identical_or_equal to test is or else __eq__ Oct 12, 2019
@windelbouwman windelbouwman merged commit 23075e5 into RustPython:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windelbouwman windelbouwman windelbouwman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @windelbouwman