Defer BigInt::clone() for new_int #1505
Conversation
| @@ -384,6 +384,17 @@ impl PyContext { | |||
| PyObject::new(PyInt::new(i), self.int_type(), None) | |||
| } | |||
|
|
|||
| #[inline] | |||
| pub fn new_bigint(&self, i: &BigInt) -> PyObjectRef { | |||
There was a problem hiding this comment.
@coolreader18 Do you have any idea to integrate this function into new_int?
There was a problem hiding this comment.
You could maybe declare your own trait and implement it for both T where T: Into<BigInt> + ToPrimitive and &T where T: Into<BigInt> + ToPrimitive. I think the real issue is that ToPrimitive should also be implemented by num-traits for &T where T: ToPrimitive.
There was a problem hiding this comment.
Thanks for the advice. But for now, I think I am not interested in working for trait puzzle.
I am sorry but would you review this PR as is again please?
|
Sorry for merging #1502 too early, I guess you were still working on it. |
|
That is ok. Actually, i thought it was done too. I am now doing a little refactoring and found related issues. |
This change will reduce useless
BigInt::clone()for a few cases.