Change rustc version in markdown #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
approved these changes
Oct 13, 2019
DEVELOPMENT.md
Outdated
| @@ -19,7 +19,7 @@ The contents of the Development Guide include: | |||
|
|
|||
| RustPython requires the following: | |||
|
|
|||
| - Rust 1.36 or higher | |||
| - Rust latest stable version (at least 1.38.0) | |||
There was a problem hiding this comment.
We could say that we require at least the stable version, without mentioning the 1.38 version, since the stable version will move forward in time. What do you think?
There was a problem hiding this comment.
That will be the most correct description. But still my rule of thumb is that people understand the version easier with specific number. Maybe ‘(e.g 1.38.0 in oct 2019)’ can be a helpful comment
There was a problem hiding this comment.
Agreed, having an explicit version number is useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mutually exclusive with #1516.That means if this PR is merged #1516 is needed to be dropped. On the other hand, if #1516 is merged this PR is needed to be dropped too.