Implement itertools.product #1526
Conversation
0f614c1 to
b5b4835
Compare
|
|
||
| #[derive(FromArgs)] | ||
| struct ProductArgs { | ||
| #[pyarg(keyword_only, optional = true)] |
There was a problem hiding this comment.
This can be an OptionalArg<usize> to avoid having to check for an overflow yourself.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
vm/src/stdlib/itertools.rs
Outdated
| struct PyIterToolsProduct { | ||
| pools: Vec<Vec<PyObjectRef>>, | ||
| idxs: RefCell<Vec<usize>>, | ||
| cur: RefCell<usize>, |
There was a problem hiding this comment.
Is this separate sizes Vec necessary? It seems like it's just the length of the Vec at the same index in pools.
There was a problem hiding this comment.
Well, it can be implemented without separate sizes but i don't know what's the benefit of not separating. Is there special reason, @coolreader18 ?
There was a problem hiding this comment.
Having them separate just seems redundant to me. I'd recommend removing sizes and just using pools[i].len().
aa07112 to
038f486
Compare
vm/src/stdlib/itertools.rs
Outdated
| #[pyimpl] | ||
| impl PyIterToolsProduct { | ||
| #[pyslot(new)] | ||
| fn new( |
There was a problem hiding this comment.
tp_new is the conventional name of this method
|
|
||
| #[derive(FromArgs)] | ||
| struct ProductArgs { | ||
| #[pyarg(keyword_only, optional = true)] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This implements `itertools.product` of standard library. Related with RustPython#1361
Well, it passes the snippet tests so I think yes. |
|
I think this looks good now! Thanks! |
This implements
itertools.productof standard library.Related with #1361