Skip to content

Separate BaseException to __init__ and __new__ #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 22, 2019
Merged

Separate BaseException to __init__ and __new__ #1598

merged 5 commits into from
Nov 22, 2019

Conversation

palaviv
Copy link
Contributor

@palaviv palaviv commented Nov 16, 2019

In CPython the BaseException initialize __traceback__, __cause__, __context__ and __suppress_context__ in __new__ and not in __init__.
Do you think this attributes should be members of PyBaseException?

@palaviv
Copy link
Contributor Author

palaviv commented Nov 17, 2019

I decided to move everything into PyBaseException

@palaviv palaviv requested a review from coolreader18 November 22, 2019 07:22
coolreader18
coolreader18 approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry for not reviewing earlier.

@palaviv palaviv merged commit aa1af71 into RustPython:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palaviv @coolreader18