Add itertools.combinations() #1603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05a134d to
3b5816a
Compare
dralley
commented
Nov 21, 2019
vm/src/stdlib/itertools.rs
Outdated
| let iter = get_iter(vm, &iterable)?; | ||
| let pool = get_all(vm, &iter)?; | ||
|
|
||
| if r < 0 { |
There was a problem hiding this comment.
I would prefer to keep r as usize, but then I don't have control over ValueError being returned when a negative value is passed in, it comes out as OverflowError instead. Is there a better way?
There was a problem hiding this comment.
You could make a new type that implements TryFromObject that stores a num_bigint::Sign and a usize. I can see that being useful in other places as well like sequence indexing.
There was a problem hiding this comment.
Ended up just copying what some of the other implementations are doing to keep it consistent. If it's usable in many places it probably makes sense as a separate improvement.
dfae03d to
455d8d6
Compare
coolreader18
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.