Add itertools.cycle() and itertools.chain.from_iterable() #1645
Conversation
| #[pymethod(name = "__next__")] | ||
| fn next(&self, vm: &VirtualMachine) -> PyResult { | ||
| let item = if let Some(item) = get_next_object(vm, &self.iter.borrow())? { | ||
| if self.first_pass.get() { |
There was a problem hiding this comment.
So I copied the CPython implementation verbatim basically, but I'm confused as to why this variable exists.
https://github.com/python/cpython/blob/master/Modules/itertoolsmodule.c#L1015-L1043
If you look at the code, it appears it is read from but never written to, except for __setstate__. It looks like a few years ago it was used in the actual algorithm, but not anymore, after this commit:
python/cpython@ca3788c#diff-2e8fa44b11c7ea371dfc1101d176ec87L953
I'm not sure whether it is left behind intentionally (needed for compatibility purposes or something) or if it was an accident.
There was a problem hiding this comment.
That's really weird; I think it's fine for now but it'll definitely be interesting to see what the CPython team thinks.
|
re: #1361 |
|
Nice work! |
No description provided.