Skip to content

objstr::get_value -> objstr::clone_value #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

objstr::get_value -> objstr::clone_value #1654

merged 1 commit into from
Jan 9, 2020

Conversation

youknowone
Copy link
Member

because the previous naming gives unclear performance estimation to
users especially comparing to objstr::borrow_value.

I also suggest one of below:

  1. Rename objstr::borrow_value -> objstr::get_value as current expectation.
  2. Rename get_values of non-copying types into borrow_value and clone_value. For now, there are bytes, int, range and tuple.

@youknowone
objstr::get_value -> objstr::clone_value
13914e0 
because the previous naming gives unclear performance estimation to
users especially comparing to objstr::borrow_value
@coolreader18 coolreader18 merged commit 156e6e1 into RustPython:master Jan 9, 2020
@youknowone youknowone deleted the clone-value branch January 9, 2020 00:25
@youknowone youknowone mentioned this pull request Feb 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @coolreader18