Refactor small things #1684
Merged
Refactor small things #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bab70a7 to
cd2d2d3
Compare
coolreader18
approved these changes
Jan 14, 2020
vm/src/vm.rs
Outdated
| @@ -764,8 +758,7 @@ impl VirtualMachine { | |||
| code_object: &bytecode::CodeObject, | |||
There was a problem hiding this comment.
Maybe we can move this to objfunction.rs so that we can make the fields all private?
There was a problem hiding this comment.
I moved a few methods and now it looks better. Will you check new commits?
3e87b39 to
ca27c20
Compare
e8a84e9 to
42ad341
Compare
42ad341 to
bf0b4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.