Skip to content

Bump up to python 3.7 for Azure Pipelines #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Jan 25, 2020

Split from #1703

Python36:
python.version: '3.6'
Python38:
python.version: '3.8'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can embed this directly in the UsePythonVersion task; I'm pretty sure this is what's causing the 2 different Azure jobs to run.

@youknowone
Copy link
Member Author

windows snippets test fail with python 3.8 but I don't have windows macine.

@palaviv
Copy link
Contributor

palaviv commented Jan 28, 2020

It seems like os.path.realpath was changed in 3.8.

@coolreader18
Copy link
Member

The os.path.realpath implementation for 3.8 is pretty complex and requires a fairly complex os module function, it might be best to comment it out for windows right now and put a TODO.

@youknowone youknowone changed the title Bump up to python 3.8 for Azure Pipelines Bump up to python 3.7 for Azure Pipelines Feb 5, 2020
@youknowone
Copy link
Member Author

Changed to python3.7 for azure

@youknowone youknowone merged commit 0f12db1 into RustPython:master Feb 5, 2020
@youknowone youknowone deleted the azure-38 branch February 5, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants