Skip to content

Implement _random.Random #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 5, 2020
Merged

Implement _random.Random #1731

merged 7 commits into from
Feb 5, 2020

Conversation

coolreader18
Copy link
Member

@coolreader18 coolreader18 commented Feb 1, 2020 •
edited
Loading

Based off of @malkoG's work in #1571. Closes #1571 and closes #1269.

cc @vks.

palaviv
palaviv reviewed Feb 1, 2020
View reviewed changes
@coolreader18 coolreader18 force-pushed the feature/implement-random branch from 6d417d5 to 9252e94 Compare February 3, 2020 04:25
@coolreader18 coolreader18 force-pushed the feature/implement-random branch from 9252e94 to b40dcb7 Compare February 4, 2020 00:22
youknowone
youknowone approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about publishing mersenne.rs as an independent crate?

@coolreader18
Copy link
Member Author

I think that would be good to do; I'll look into it.

@coolreader18 coolreader18 merged commit c435ba0 into master Feb 5, 2020
@coolreader18 coolreader18 deleted the feature/implement-random branch February 17, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palaviv palaviv palaviv left review comments

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Determinism and compatibility of random module
4 participants
@coolreader18 @youknowone @palaviv @malkoG