-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add getset_descriptor #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getset_descriptor #1738
Conversation
How is PyGetSet different from PyProperty? |
in CPython, PyGetSet corresponds to Practically, it is only created with native functions with solid getter and setter signature. So it must be related to performance. For compatibility point of view, the properties of |
cdcec67
to
ced2423
Compare
Maybe it would be good to replace all the property APIs ( |
After grep CPython code, yes, that sounds true. |
451fc24
to
4eca2b0
Compare
876d468
to
2bce242
Compare
07a6bba
to
7626f13
Compare
556a919
to
5b270b4
Compare
@coolreader18 It seems this is finally done! will you review it please? |
I attached #1736 to here because it is trivial derived work from this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I had one note about the getters/setters for SyntaxError but otherwise feel free to merge.
Other getters of SyntaxError are actually not a getter by args. they are attributes set by |
Uh oh!
There was an error while loading. Please reload this page.