Fix some clippy lints that were previously 'allow'ed #1843
Conversation
| @@ -768,8 +768,7 @@ impl VirtualMachine { | |||
| self.trace_event(TraceEvent::Return)?; | |||
| result | |||
| } else if class.has_attr("__call__") { | |||
| let result = self.call_method(&callable, "__call__", args); | |||
| result | |||
| self.call_method(&callable, "__call__", args) | |||
There was a problem hiding this comment.
These patterns were actually more debugger-friendly than now.
Do we prefer cleaner code than debugger friendly code?
There was a problem hiding this comment.
Oh, like being able to see the value of result there? I'm not sure, I don't use traditional debuggers that let you step through, but I'd think that there might be some way to see the value of an expression after it executes? I'm not sure.
There was a problem hiding this comment.
Yes, exactly that use case. I just know this kind of "single expression for one line" or "single side effect for one line" is a traditional recommendation for debugger-friendly code. Because I am not a heavy user of debuggers, probably there must be experts who know better about this problem.
No description provided.