Skip to content

Direct print() to sys.stdout #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

Direct print() to sys.stdout #1846

merged 1 commit into from
Apr 8, 2020

Conversation

coolreader18
Copy link
Member

@coolreader18 coolreader18 commented Apr 7, 2020 •
edited
Loading

This allows e.g. contextlib.redirect_stdout to work with print()

@coolreader18 coolreader18 requested a review from youknowone April 8, 2020 15:22
youknowone
youknowone reviewed Apr 8, 2020
View reviewed changes
@youknowone
Copy link
Member

I don't think I know enough about this topic. Could anyone review this PR? @palaviv @windelbouwman

@coolreader18 coolreader18 force-pushed the coolreader18/print-sys-stdout branch from 30a6de3 to 505341d Compare April 8, 2020 16:30
@coolreader18 coolreader18 force-pushed the coolreader18/print-sys-stdout branch from 505341d to 2cd42c5 Compare April 8, 2020 17:10
@coolreader18 coolreader18 changed the title print() to sys.stdout if it's not actually stdout Direct print() to sys.stdout Apr 8, 2020
youknowone
youknowone approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version looks a lot simpler :)

@coolreader18 coolreader18 merged commit 3eb687d into master Apr 8, 2020
@coolreader18 coolreader18 deleted the coolreader18/print-sys-stdout branch April 8, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolreader18 @youknowone