Skip to content

Enable the os and io modules on wasi #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

Enable the os and io modules on wasi #1872

merged 1 commit into from
Apr 17, 2020

Conversation

coolreader18
Copy link
Member

No description provided.

@coolreader18 coolreader18 force-pushed the coolreader18/wasi-io branch from 8b791b2 to fc6de65 Compare April 16, 2020 19:00
@coolreader18 coolreader18 force-pushed the coolreader18/wasi-io branch from fc6de65 to 9a6509d Compare April 16, 2020 20:26
palaviv
palaviv approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@palaviv palaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there a way for us to test this in the CI?

@coolreader18
Copy link
Member Author

I think we could test in CI, I'll look into it separately, though.

@coolreader18 coolreader18 merged commit 5ee6ca6 into master Apr 17, 2020
@coolreader18 coolreader18 deleted the coolreader18/wasi-io branch April 17, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palaviv palaviv palaviv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolreader18 @palaviv