-
Notifications
You must be signed in to change notification settings - Fork 1.3k
The any key/p38 self documenting fstrings #1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
coolreader18
merged 14 commits into
RustPython:master
from
TheAnyKey:TheAnyKey/p38_self_documenting_fstrings
May 5, 2020
Merged
The any key/p38 self documenting fstrings #1899
coolreader18
merged 14 commits into
RustPython:master
from
TheAnyKey:TheAnyKey/p38_self_documenting_fstrings
May 5, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handling of quotes is too simple
youknowone
previously requested changes
May 4, 2020
Co-authored-by: Jeong YunWon <youknowone@users.noreply.github.com>
coolreader18
approved these changes
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes for fstring:
fix: so far it was not allowed that a conversion flag is followed by a format specifier.
so far f"{'42'!s:10}" rose a parsing error as a '}' was expected after a conversion flag.This is fix now.
implemented self documenting fstrings in rustpython
I implemented the self documenting fstrings in rustpython, as introduced with python 3.8. I.e., the following syntax is now allowed:
Also combination with conversion flags and format specs are supported.
Open: the behaviour when the type of the expression is a string is so far not conform to cpython, thus those are temporarily modified or skipped.
Ported tests from cpython for self documenting fstrings (and some more for format spec handling)
Imported the tests for selfdocumentign fstrings from cpython to rustpython.