Skip to content

Implement subprocess using _posixsubprocess and _winapi #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 26, 2020

Conversation

coolreader18
Copy link
Member

No description provided.

@coolreader18 coolreader18 force-pushed the coolreader18/subprocess-py branch 3 times, most recently from ae89e71 to 511ee56 Compare June 10, 2020 23:07
@@ -101,7 +102,6 @@ uname = "0.1.1"
crc32fast = "1.2.0"
adler32 = "1.0.3"
gethostname = "0.2.0"
subprocess = "0.2.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the subprocess library. What are we missing in the library? The maintainer is very responsive so we should consider just asking him to add what we need.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe due to platform compatibility like _posixsubprocess?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's generally more difficult to implement an API with a large surface area than it is to implement the low-level primitives it's based on. This also guarantees parity in the implementation, since there could be a subtle disparity between cpython's _posixsubprocess or windows subprocess implementation and the subprocess crate that causes some weird bug. This way we know that as long as the fork_exec or CreateProcess code (which are pretty small) are equivalent, then so should the subprocess module.

youknowone added a commit that referenced this pull request Jun 21, 2020
@coolreader18 coolreader18 force-pushed the coolreader18/subprocess-py branch from 129366c to 04f3033 Compare June 21, 2020 21:04
@coolreader18 coolreader18 force-pushed the coolreader18/subprocess-py branch 4 times, most recently from 56157cf to e06641d Compare June 22, 2020 04:10
Copy link
Contributor

@palaviv palaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry for the late review

@coolreader18 coolreader18 merged commit 31c9947 into master Jun 26, 2020
@coolreader18 coolreader18 deleted the coolreader18/subprocess-py branch June 26, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants