Skip to content

Refactor DictKey #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2020
Merged

Refactor DictKey #2035

merged 2 commits into from
Aug 3, 2020

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Jul 28, 2020 •
edited
Loading

This patch make DictKey used in more natural manner - except for &str case.

@youknowone
Copy link
Member Author

youknowone commented Jul 28, 2020 •
edited
Loading

Um.. I have no idea why changing hash function for str cause crashes. Is this related to frozenlib?

I splited PR to #2036 for failing part

This was referenced Jul 28, 2020
Merged
Merged
@youknowone youknowone requested a review from coolreader18 August 3, 2020 16:34
coolreader18
coolreader18 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I really like the generic ItemProtocol, since anything can be passed to obj.__getitem__() but only some objects can be dict keys.

@youknowone youknowone merged commit 1249fab into RustPython:master Aug 3, 2020
@youknowone youknowone deleted the dictkey branch August 3, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @coolreader18