-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Reorganize os module #2041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize os module #2041
Conversation
f57f697
to
7b2441e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, is there any concern about span info being lost or was that fixed with rust 1.45 and proc_macro_hygiene?
Sorry, I am not aware of that topic at all. Is it a debug info problem or could it make an actual bug? |
I'm not sure exactly, I haven't actually seen an issue for it in rust-lang/rust, but there was some stuff in the latest version related to proc macros. Does the issue with error locations not showing up still happen (#1832 (comment))? |
When signature is wrong, for pyfunction:
For inner class method:
Calling the function out of the module:
I have no idea what kind of error was in that comment. To be honest, I didn't have any serious problem while working with pymodule. so I am afraid I am not a suitable person to say this is happening or not. |
@palaviv any idea how to make the untrackable error? |
Go for this and let's see how things go. Even when it has problem, it doesn't look commonly making very serious issue, and it will be eventually solved by rust itself. |
Oh, I found it. nested macro expanding or errors in generated code makes the error messages weird |
This PR re-cluster os module with 3 submodules
posix
,nt
andminor
.I think current result is not the ideal state but this was limit for me due to lack of windows dev enviroment.