Change dis.dis to take strings to decompile #2054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the dis module's dis function only accepts functions tp decompile. This adds support for disassembling strings. It does this by compiling the string, then disassembling compiled output.
As of this commit, these tests fail.
This was chaned because stdout is being written to by rust code, which currently can't be redirected by reassigning sys.stdout. This caused the tests to fail because they couldn't see the output of what was being tested.
youknowone
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the dis function from the dis module can only take functions to decompile. This changes it so that strings, when passed to dis, are compiled then disassembled.
This also includes tests for the dis module.