Skip to content

Fix zlib decompression #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2020
Merged

Fix zlib decompression #2060

merged 3 commits into from
Aug 2, 2020

Conversation

BenLewis-Seequent
Copy link

Fixed a couple of bugs with zlib decompression, and shared the core decompression routine between zlib_decompress, Decompress.decompress, and Decompress.flush.

@youknowone youknowone requested a review from coolreader18 August 2, 2020 08:08
coolreader18
coolreader18 approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Btw, I sent you a message on gitter, would you be able to check that?

@coolreader18 coolreader18 merged commit 3d5ea1b into RustPython:master Aug 2, 2020
@BenLewis-Seequent BenLewis-Seequent deleted the zlib_decompress branch August 8, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenLewis-Seequent @youknowone @coolreader18 @skinnyBat