Skip to content

Expose sys module constants in rust level #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

youknowone
Copy link
Member

No description provided.

@@ -16,6 +16,8 @@ use crate::{builtins, exceptions, py_io, version};
/*
* The magic sys module.
*/
const MAXSIZE: usize = std::isize::MAX as usize;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coolreader18
Copy link
Member

I'm not sure... I feel like it doesn't totally make sense to have it in the stdlib directory, since it's more a function of the python interpreter rather than the standard library, and that's why CPython has it as Python/sysmodule.c. Like, why not put the builtins module in stdlib/? I think it's the same sort of thing.

@youknowone youknowone changed the title move sysmodule to stdlib/sys Expose sys module constants in rust level Oct 30, 2020
@youknowone
Copy link
Member Author

I removed the movnig part and remained only constant exposure part

@youknowone youknowone merged commit cd415c6 into RustPython:master Nov 2, 2020
@youknowone youknowone deleted the sysmodule branch November 2, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants