Add string interning #2325
Add string interning #2325
Conversation
|
Ah, crap, I meant to make the rustpython_bytecode::bytecode flattening a separate commit, one sec |
039086c to
3fc525d
Compare
2448976 to
9fa7014
Compare
|
Alright, this is good for review now |
9fa7014 to
2f232ec
Compare
| @@ -172,37 +181,39 @@ pub enum ConversionFlag { | |||
| Repr, | |||
| } | |||
|
|
|||
| pub type NameIdx = usize; | |||
There was a problem hiding this comment.
is this intended to be used with arithmatic operations? otherwise, I think struct(usize) would be better.
| bytecode::BorrowedConstant::Str { value } if value.len() <= 20 => { | ||
| vm.intern_string(value).into_object() | ||
| } | ||
| bytecode::BorrowedConstant::Str { value } => vm.ctx.new_str(value), |
There was a problem hiding this comment.
Does constant interning also affect by string length?
There was a problem hiding this comment.
Oh, I think I confused it with this, it should be interned still
Yeah, so it's a lot easier to deal with interning if you know that everything in the dict is a strict |
./rustpython-norm benchmarks/pystone.py 500000./rustpython-opt benchmarks/pystone.py 500000