Make `dict()` work like it does in cpython #236

coolreader18 · 2018-12-22T05:38:53Z

e.g.

dict(a=2, b=3) == {'a': 2, 'b': 3}
dict({'a': 2, 'b': 3}, b=4) == {'a': 2, 'b': 4}
dict([('a', 2), ('b', 3)]) == {'a': 2, 'b': 3}

e.g. ``` dict(a=2, b=3) == {"a": 2, "b": 3} ```

windelbouwman · 2018-12-22T15:04:25Z

Nice!

windelbouwman · 2018-12-22T15:05:18Z

vm/src/obj/objdict.rs

+        required = [(_ty, Some(vm.ctx.type_type()))],
+        optional = [(dict_obj, None)]
+    );
+    let dict = vm.ctx.new_dict();


Here, we could potentially use _ty to support dict subclasses as well.

coolreader18 added 3 commits December 18, 2018 01:34

dict() now should work properly

bdc80dc

e.g. ``` dict(a=2, b=3) == {"a": 2, "b": 3} ```

Finish revamping dict_new()

f178423

Add test for dicts

427ce43

windelbouwman reviewed Dec 22, 2018

View reviewed changes

windelbouwman merged commit 366f3e2 into RustPython:master Dec 22, 2018

coolreader18 deleted the proper-dict branch December 22, 2018 18:01

Provide feedback