Implement most of the string methods. #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval_py(`return js_vars["a"]`, { a: 9 }) == 9
e.g.
``` dict(a=2, b=3) == {"a": 2, "b": 3} ```
Also, switch from iterating over the values of js_injections and serializing each of them individually to asserting it's an object and then just stringifying the whole thing.
This is a separate opcode in CPython so I added it as such here.
|
@AgentMacklin thank you for your contribution! An automated test appears to fail, could you have a look at this? |
|
Okay, it turns out python3.6 doesn't implement isascii() like 3.7 does and I didn't realize at the time. Everything runs smoothly now :) |
|
I'll merge this right on. I'll squash the commits since some rebase action was done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not mistaken this covers just about the rest of the string methods, with the exception of maketrans() and translate(). I also added the appropriate test snippets.