Implements AST Customization (#2388) #2394
Conversation
|
(The clippy error is a separate issue, addressed in #2392) Is this ready to be merged? Or will you implement custom-type mapping inside rustpython-ast? |
parser/src/python.lalrpop
Outdated
| @@ -69,6 +69,7 @@ PassStatement: ast::Statement = { | |||
| <location:@L> "pass" => { | |||
| ast::Statement { | |||
| location, | |||
| custom: Default::default(), | |||
There was a problem hiding this comment.
Is there a reason these can't be custom: () as well? If you were looking to eventually have the parser be generic, custom: () can be easily find/replaced eventually.
There was a problem hiding this comment.
I was looking to have the parser be generic later, but () seems to be clearer. will fix.
I think custom-type mapping can be done in a separate PR, as that would probably be pretty large, as the AST involves quite a lot of structs. |
|
Could you switch out all the |
|
Thanks for contributing! |
Tested with
cargo testinast,parserandcompilerdirectory (ascargo test --allwould fail to compile for wasm...)