Allow importing PyPI packages on wasm #2442
Conversation
|
That's nifty! For my purposes the package doesn't come from PyPI though, since it needs to reflect the current master branch. |
|
Ah, it looked like in demo.js it was downloading from pypi. Regardless, this can be extended to fetch any wheel, so as long as a Pygments.whl is built for the master branch this can work with that easily. |
ec3b2cc to
de357d2
Compare
fc55f3e to
0a9da8c
Compare
|
How far would this feature eventually reach? Would it for example be possible to load numpy? |
|
@jhoobergs maybe, but we can't load numpy at all at the moment, so it would be dependent on how extension modules eventually work. The |
30ddb60 to
d39e743
Compare
vm/src/stdlib/zlib.rs
Outdated
| #[cfg(not(feature = "zlib"))] | ||
| Self::Standard { header } => Compress::new(level, header), |
There was a problem hiding this comment.
if this one doesn't share condition with the others, is this needed to be placed between feature = "zlib"?
There was a problem hiding this comment.
I moved it above the feature = "zlib" branches.
d39e743 to
28a2697
Compare
cc @birkenfeld