Limit the deployment only to the specific build job #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will fix #249 |
.travis.yml
Outdated
| @@ -99,6 +101,7 @@ deploy: | |||
| keep-history: true | |||
| on: | |||
| branch: release | |||
| condition: $DEPLOY_DOC=ture | |||
There was a problem hiding this comment.
There is a typo on true here. Below as well.
.travis.yml
Outdated
| @@ -109,3 +112,4 @@ deploy: | |||
| keep-history: true | |||
| on: | |||
| branch: release | |||
| condition: $DEPLOY_DEMO=ture | |||
There was a problem hiding this comment.
Note the typo on ture
5e0b020 to
7c8ebee
Compare
|
I also made a typo on branch name, jammer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if you push to the
releasebranch, the deployment will run on every test suite. So all of them fails. We only wantpublish documentationto deploy toRustPython/docsandWASM online demoto release toRustPython/demo.I can't seem to find a way to put the deployment as a post-build step for just one test suite, so I use this ugly environment variable to limit that.
Also here is a sample of a failed build: https://travis-ci.org/RustPython/RustPython/builds/476271838