Skip to content

Fix the deploy condition for missing spaces around equals sign #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Fix the deploy condition for missing spaces around equals sign #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ deploy:
keep-history: true
on:
branch: release
condition: $DEPLOY_DOC=true
condition: $DEPLOY_DOC = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be DEPLOY_DOC=true? Without the dollar symbol?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on in the deployment section seems to be different from the if elsewhere. Here is the quote form the doc:

condition: deploy when a single bash condition evaluates to true. This must be a string value, and is equivalent to if [[ <condition> ]]; then <deploy>; fi. For example, $CC = gcc.

Here is a working build: https://travis-ci.org/RustPython/RustPython/builds/478843944 . The deployment steps failed because I set a bad token to avoid actually deploying. But the deployment step seems to kick-off correctly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is pretty crappy, but good research!

- provider: pages
repo: RustPython/demo
target-branch: master
Expand All @@ -112,4 +112,4 @@ deploy:
keep-history: true
on:
branch: release
condition: $DEPLOY_DEMO=true
condition: $DEPLOY_DEMO = true