Change OSError and its subclasses attributes #2993
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #2974. Haven't been paying much attention to it but you might want to see the updates there since they should affect how this PR should try and implement this. |
832ffad to
322057e
Compare
cae22df to
4792bab
Compare
Merged
4792bab to
bbf87c7
Compare
youknowone
previously approved these changes
Oct 30, 2021
vm/src/exceptions.rs
Outdated
| @@ -949,6 +949,7 @@ pub(super) mod types { | |||
| use crate::{ | |||
| builtins::{traceback::PyTracebackRef, PyInt, PyTupleRef, PyTypeRef}, | |||
| function::{FuncArgs, IntoPyResult}, | |||
| pyobject::{PyValue, TypeProtocol}, | |||
There was a problem hiding this comment.
Suggested change
| pyobject::{PyValue, TypeProtocol}, | |
| PyValue, TypeProtocol, |
0a75d79 to
e84bcb6
Compare
|
@deantvv could you review this PR? |
deantvv
reviewed
Nov 6, 2021
vm/src/exceptions.rs
Outdated
| } | ||
|
|
||
| fn os_error_parse_args( | ||
| exc_self: PyBaseExceptionRef, |
There was a problem hiding this comment.
Suggested change
| exc_self: PyBaseExceptionRef, | |
| exc_self: &PyBaseExceptionRef, |
There was a problem hiding this comment.
We could use the reference to remove some clone.
86e6443 to
8158379
Compare
3f534a4 to
72bc663
Compare
72bc663 to
6138130
Compare
6138130 to
ee9f041
Compare
ee9f041 to
cd32e67
Compare
1c6547e to
48b6860
Compare
9b4598c to
9617789
Compare
Make errno, strerror of OSError from readonly to attributes Add OSError's attributes even they are None
9617789 to
db53fd2
Compare
|
Too old to fix the codes. I close this PR and will check other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides specified attribute "characters_written" to BlockingIOError. Other unnecessary attributes are ignored in BlockingIOError such as winerror, filename, filename2.