Skip to content

Add test_import from CPython 3.8 #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add test_import from CPython 3.8 #3018

wants to merge 3 commits into from

Conversation

fanninpm
Copy link
Contributor

@fanninpm fanninpm commented Sep 6, 2021

No description provided.

@fanninpm
Copy link
Contributor Author

fanninpm commented Sep 6, 2021

I can't reproduce the CI failures locally.

@DimitrisJim
Copy link
Member

DimitrisJim commented Sep 9, 2021 •
edited
Loading

Hm, I'm actually getting errors for test_os.py. Are things still passing locally for you?

@fanninpm
Copy link
Contributor Author

Hm, I'm actually getting errors for test_os.py. Are things still passing locally for you?

I'm not getting any failures, but I am getting a few instances of OverflowError: Python int too large to convert to Rust u32. These seem to happen with test_setregid_neg1 and test_setreuid_neg1.

@DimitrisJim
Copy link
Member

DimitrisJim commented Sep 27, 2021 •
edited
Loading

Bump, I ran these again and indeed I locally cannot repro the errors (something weird was going on when I tried to run tests last time).

It looks like test_import is failing on Windows while test_unittest is failing on the others. If these failures are just one or two functions we could probably just skip for CI as we usually do.

@youknowone
Copy link
Member

test_import 3.11 is merged by #4599

@youknowone youknowone closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanninpm @DimitrisJim @youknowone