Fix failed test remainder in test_math #3037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add conditions for below rules 1. remainder(x, inf) is x, for non-NaN non-infinite x 2. According to IEEE 754-2008 7.2(f) 2-1. remainder(x, 0) for non-NaN x is invalid operation 2-2. remainder(infinity, x) for non-NaN x is invalid operation
DimitrisJim
requested changes
Sep 11, 2021
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
DimitrisJim
approved these changes
Sep 11, 2021
There was a problem hiding this comment.
lgtm now.
I'm under the impression a similar set of checks is done for other functions too (looking through the CPython code FUNC_2 wraps many (double, double) -> double funcs). Don't know what the other functions in math.rs do currently but I'm guessing there's lots of duplicated code checking these same edge cases.
Not requesting this now, it just seems like a good refactoring opportunity if you'd be interested.
|
I think we need a utility for "math domain error". it appears everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add conditions for below rules (specified in test codes)
2-1. remainder(x, 0) for non-NaN x is invalid operation
2-2. remainder(infinity, x) for non-NaN x is invalid operation