Skip to content

Add cmath log() and log10() methods #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2021
Merged

Add cmath log() and log10() methods #3075

merged 4 commits into from
Sep 18, 2021

Conversation

ConnorTroy
Copy link
Contributor

Relates to #3039

Added cmath.log() and cmath.log10()

DimitrisJim
DimitrisJim requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only nitpick is docstrings, we match them with CPythons in as many places as possible.

ConnorTroy and others added 2 commits September 17, 2021 01:23
@ConnorTroy @DimitrisJim
Update cmath log docstring to match CPython
9013505 
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
@ConnorTroy @DimitrisJim
Update cmath log10 docstring to match CPython
36fb58d 
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
@youknowone youknowone merged commit cf6d3c4 into RustPython:main Sep 18, 2021
@ConnorTroy ConnorTroy deleted the cmath-log-log10 branch September 18, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConnorTroy @DimitrisJim @youknowone