rustpython-vm public API for rustpython-stdlib #3104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
commented
Sep 21, 2021
vm/src/builtins/mod.rs
Outdated
| @@ -80,5 +80,9 @@ pub(crate) mod zip; | |||
| pub use zip::PyZip; | |||
| pub(crate) mod genericalias; | |||
|
|
|||
| pub use super::exceptions::{PyBaseException, PyBaseExceptionRef}; | |||
There was a problem hiding this comment.
In the view of public API, these types are not distinguishable with other built-in types
vm/src/lib.rs
Outdated
Comment on lines
81
to
83
| pub mod protocols { | ||
| pub use super::buffer::{PyBuffer, PyBufferInternal}; | ||
| pub use super::slots::PyIter; | ||
| } |
There was a problem hiding this comment.
new module protocols for python c-api protocols
dd84cd8 to
4541ce6
Compare
This was referenced Sep 21, 2021
4541ce6 to
71101f6
Compare
This was referenced Sep 22, 2021
Merged
71101f6 to
d1252c2
Compare
2552210 to
f9eedf5
Compare
Merged
e6c39ad to
03d513f
Compare
This was referenced Sep 26, 2021
03d513f to
6035c59
Compare
Merged
6035c59 to
b8929e6
Compare
9d4e9ee to
2b822ff
Compare
64f8c51 to
90cb222
Compare
|
merged as part of #3129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #3102