Skip to content

Universal mechanism for Iterator slots #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2021
Merged

Universal mechanism for Iterator slots #3116

merged 1 commit into from
Sep 24, 2021
+117 −43

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Sep 22, 2021 •
edited
Loading

Adaptable for any kind of iterable/iterator with new machanism.
So now io::_IOBase also can implement Iterable and PyIter

This is the same strategy with Hashable and Unhashable

@youknowone youknowone mentioned this pull request Sep 22, 2021
Merged
@youknowone youknowone force-pushed the pyiter branch 3 times, most recently from 160dc9f to 8a27d30 Compare September 24, 2021 04:53
@youknowone youknowone changed the title Universal machanism for Iterator slots Universal mechanism for Iterator slots Sep 24, 2021
coolreader18
coolreader18 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youknowone youknowone merged commit 1063121 into RustPython:main Sep 24, 2021
@youknowone youknowone deleted the pyiter branch September 24, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @coolreader18