Skip to content

PyIter protocol object #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2021
Merged

PyIter protocol object #3117

merged 2 commits into from
Sep 29, 2021

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Sep 22, 2021 •
edited
Loading

based on #3115 and #3116

will be part of #3104 because PyIter is required for stdlib modules

@youknowone youknowone changed the title Pyiter protocol PyIter protocol object Sep 23, 2021
@youknowone youknowone force-pushed the pyiter-protocol branch 4 times, most recently from 750687e to f965792 Compare September 27, 2021 16:13
@youknowone
Copy link
Member Author

youknowone commented Sep 29, 2021 •
edited
Loading

@DimitrisJim could you review this PR? First commit is simple type name replacement. Second commit is actual protocol implementation

DimitrisJim
DimitrisJim reviewed Sep 29, 2021
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DimitrisJim DimitrisJim merged commit a3c06d9 into RustPython:main Sep 29, 2021
@youknowone youknowone deleted the pyiter-protocol branch September 30, 2021 16:43
@youknowone youknowone mentioned this pull request Sep 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @DimitrisJim