Skip to content

rustpython-stdlib crate #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 30, 2021
Merged

rustpython-stdlib crate #3129

merged 8 commits into from
Sep 30, 2021

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Sep 25, 2021 •
edited
Loading

@youknowone youknowone changed the title Rustpython stdlib rustpython-stdlib crate Sep 25, 2021
@youknowone youknowone force-pushed the rustpython-stdlib branch 3 times, most recently from 35e2dc0 to 90c1972 Compare September 25, 2021 17:30
@youknowone youknowone mentioned this pull request Sep 25, 2021
Merged
@youknowone youknowone force-pushed the rustpython-stdlib branch 6 times, most recently from 2280760 to 0db8589 Compare September 26, 2021 17:44
@youknowone
Copy link
Member Author

done except for windows

@youknowone youknowone force-pushed the rustpython-stdlib branch 4 times, most recently from c67d1f6 to d27785a Compare September 27, 2021 17:41
This was referenced Sep 27, 2021
Closed
Merged
Merged
DimitrisJim
DimitrisJim reviewed Sep 27, 2021
View reviewed changes
@youknowone youknowone force-pushed the rustpython-stdlib branch 9 times, most recently from 31f2ac1 to 8fc0025 Compare September 30, 2021 07:40
@youknowone youknowone marked this pull request as ready for review September 30, 2021 07:41
@youknowone
Copy link
Member Author

@DimitrisJim @coolreader18 there will be more things to do (e.g. corelib), but I want to finish this PR for current state and do further works later.

youknowone
youknowone commented Sep 30, 2021
View reviewed changes
stdlib/src/lib.rs
#[cfg(all(unix, not(target_os = "redox")))]
mod termios;

use rustpython_common as common;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intended to be used like vm::common?

@coolreader18
Copy link
Member

LGTM!

@DimitrisJim DimitrisJim merged commit 30fd99f into RustPython:main Sep 30, 2021
This was referenced Oct 1, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowone @coolreader18 @DimitrisJim