Skip to content

Expose exception types under vm::builtins #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion derive/src/pyclass.rs
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ pub(crate) fn impl_define_exception(

#[pymethod(magic)]
pub(crate) fn init(
zelf: ::rustpython_vm::PyRef<::rustpython_vm::exceptions::PyBaseException>,
zelf: ::rustpython_vm::PyRef<::rustpython_vm::builtins::PyBaseException>,
args: ::rustpython_vm::function::FuncArgs,
vm: &::rustpython_vm::VirtualMachine,
) -> ::rustpython_vm::PyResult<()> {
Expand Down
3 changes: 2 additions & 1 deletion src/shell.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ mod helper;
use rustpython_parser::error::{LexicalErrorType, ParseErrorType};
use rustpython_vm::readline::{Readline, ReadlineResult};
use rustpython_vm::{
builtins::PyBaseExceptionRef,
compile::{self, CompileError, CompileErrorType},
exceptions::{print_exception, PyBaseExceptionRef},
exceptions::print_exception,
scope::Scope,
PyResult, TypeProtocol, VirtualMachine,
};
Expand Down
2 changes: 1 addition & 1 deletion vm/src/builtins/asyncgenerator.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use super::{PyCode, PyStrRef, PyTypeRef};
use crate::{
builtins::PyBaseExceptionRef,
coroutine::{Coro, Variant},
exceptions::PyBaseExceptionRef,
frame::FrameRef,
function::OptionalArg,
slots::{IteratorIterable, PyIter},
Expand Down
2 changes: 1 addition & 1 deletion vm/src/builtins/dict.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
use super::{IterStatus, PySet, PyStrRef, PyTypeRef};
use crate::{
builtins::PyBaseExceptionRef,
common::ascii,
dictdatatype::{self, DictKey},
exceptions::PyBaseExceptionRef,
function::{ArgIterable, FuncArgs, KwArgs, OptionalArg},
iterator,
slots::{Comparable, Hashable, Iterable, IteratorIterable, PyComparisonOp, PyIter, Unhashable},
Expand Down
15 changes: 6 additions & 9 deletions vm/src/builtins/function/jitfunc.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
use crate::builtins::dict::PyDictRef;
use crate::builtins::function::{PyFunction, PyFunctionRef};
use crate::builtins::{float, int, pybool, PyStrRef};
use crate::bytecode::CodeFlags;
use crate::exceptions::PyBaseExceptionRef;
use crate::function::FuncArgs;
use crate::VirtualMachine;
use crate::{
IdProtocol, IntoPyObject, ItemProtocol, PyObjectRef, PyResult, TryFromObject, TypeProtocol,
builtins::{float, int, pybool, PyBaseExceptionRef, PyDictRef, PyFunction, PyStrRef},
bytecode::CodeFlags,
function::FuncArgs,
IdProtocol, IntoPyObject, ItemProtocol, PyObjectRef, PyRef, PyResult, TryFromObject,
TypeProtocol, VirtualMachine,
};
use num_traits::ToPrimitive;
use rustpython_jit::{AbiValue, Args, CompiledCode, JitArgumentError, JitType};
Expand Down Expand Up @@ -66,7 +63,7 @@ fn get_jit_arg_type(dict: &PyDictRef, name: &str, vm: &VirtualMachine) -> PyResu
}
}

pub fn get_jit_arg_types(func: &PyFunctionRef, vm: &VirtualMachine) -> PyResult<Vec<JitType>> {
pub fn get_jit_arg_types(func: &PyRef<PyFunction>, vm: &VirtualMachine) -> PyResult<Vec<JitType>> {
let arg_names = func.code.arg_names();

if func
Expand Down
2 changes: 2 additions & 0 deletions vm/src/builtins/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,5 @@ pub use int::try_to_float as try_bigint_to_f64;

mod make_module;
pub use make_module::{ascii, make_module, print};

pub use crate::exceptions::types::*;
5 changes: 2 additions & 3 deletions vm/src/builtins/singletons.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
use super::PyTypeRef;
use crate::{
slots::SlotConstructor, IntoPyObject, PyClassImpl, PyContext, PyObjectRef, PyRef, PyResult,
PyValue, TypeProtocol, VirtualMachine,
slots::SlotConstructor, IntoPyObject, PyClassImpl, PyContext, PyObjectRef, PyResult, PyValue,
TypeProtocol, VirtualMachine,
};

#[pyclass(module = false, name = "NoneType")]
#[derive(Debug)]
pub struct PyNone;
pub type PyNoneRef = PyRef<PyNone>;

impl PyValue for PyNone {
fn class(vm: &VirtualMachine) -> &PyTypeRef {
Expand Down
12 changes: 6 additions & 6 deletions vm/src/codecs.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
use crate::{
builtins::{PyBaseExceptionRef, PyBytesRef, PyStr, PyStrRef, PyTuple, PyTupleRef},
common::{ascii, lock::PyRwLock},
IntoPyObject, PyContext, PyObjectRef, PyResult, PyValue, TryFromObject, TypeProtocol,
VirtualMachine,
};
use std::borrow::Cow;
use std::collections::HashMap;
use std::ops::Range;

use crate::builtins::{PyBytesRef, PyStr, PyStrRef, PyTuple, PyTupleRef};
use crate::common::{ascii, lock::PyRwLock};
use crate::exceptions::PyBaseExceptionRef;
use crate::VirtualMachine;
use crate::{IntoPyObject, PyContext, PyObjectRef, PyResult, PyValue, TryFromObject, TypeProtocol};

pub struct CodecsRegistry {
inner: PyRwLock<RegistryInner>,
}
Expand Down
14 changes: 7 additions & 7 deletions vm/src/coroutine.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
use crate::builtins::{PyStrRef, PyTypeRef};
use crate::exceptions::{self, PyBaseExceptionRef};
use crate::frame::{ExecutionResult, FrameRef};
use crate::VirtualMachine;
use crate::{PyObjectRef, PyResult, TypeProtocol};

use crate::common::lock::PyMutex;
use crate::{
builtins::{PyBaseExceptionRef, PyStrRef, PyTypeRef},
common::lock::PyMutex,
exceptions,
frame::{ExecutionResult, FrameRef},
PyObjectRef, PyResult, TypeProtocol, VirtualMachine,
};
use crossbeam_utils::atomic::AtomicCell;

#[derive(Debug, PartialEq, Clone, Copy)]
Expand Down
Loading