Miscellaneous pip fixes #3158
Miscellaneous pip fixes #3158
Conversation
46f5732 to
32aa7d4
Compare
32aa7d4 to
a2ea925
Compare
| @@ -66,6 +66,10 @@ path = "src/main.rs" | |||
| [profile.dev.package."*"] | |||
| opt-level = 3 | |||
|
|
|||
| [profile.test] | |||
| opt-level = 3 | |||
There was a problem hiding this comment.
doesn't this obfuscate backtrace and debug information?
how do you think about running tests with release build job if this is desired?
There was a problem hiding this comment.
It should still keep debug info I'm pretty sure - the default for test enables debuginfo and I'm pretty sure it's orthogonal to opt-level: https://doc.rust-lang.org/nightly/cargo/reference/profiles.html#test
There was a problem hiding this comment.
When opt-level is not 0, the inlined callstacks are omitted, the progress is not linear to the code and some breakpoint doesn't work.
There was a problem hiding this comment.
I think the default development environment is better to be friendly to programmers unless there are unavoidable reasons
|
13 unexpected successes from a test that wasn't in the codebase when you opened this — sounds like another reason for bors. |
Fix pip warnings about inconsistency between distutils' sysconfig and the actual sysconfig; fix error when installing package it would say something like
__env_pip__.zip is not a file