Skip to content

pub(crate) for type modules #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2021
Merged

pub(crate) for type modules #3169

merged 1 commit into from
Oct 2, 2021

Conversation

youknowone
Copy link
Member

there are no pub free functions exposed in this way.

DimitrisJim
DimitrisJim approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, have you investigated why android complains for the check?

@youknowone
Copy link
Member Author

youknowone commented Oct 1, 2021 •
edited
Loading

No I didn't. I think it is just simply because android is not using PyMapping somewhere. Those stuff will be completely removed by #3121. So they will not be a problem anymore.

To make warnings clear, I will merge this PR once after #3121 is done.

@youknowone youknowone merged commit e27b9ae into RustPython:main Oct 2, 2021
@youknowone youknowone deleted the hide-type-modules branch October 2, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @DimitrisJim