Add sinh and cosh to cmath implementation #3181
Conversation
Lib/test/test_cmath.py
Outdated
| @requires_IEEE_754 | ||
| def testSinhSign(self): | ||
| for z in complex_zeros: | ||
| self.assertComplexIdentical(cmath.sinh(z), z) | ||
|
|
||
| @requires_IEEE_754 | ||
| def testCoshSign(self): | ||
| for z in complex_zeros: | ||
| # since we are only dealing with complex zeros for the test | ||
| # this is an easy way to get the imaginary sign | ||
| imaginary = 0.0 * z.real * z.imag | ||
| self.assertComplexIdentical(cmath.cosh(z), complex(1.0, imaginary)) | ||
|
|
There was a problem hiding this comment.
Please avoid adding original codes to this file. If this tests are originated from CPython same file (Lib/test/test_cmath.py), separate the commit for this update and add CPython version to the commit message.
If you need these own tests, extra_tests/snippets/complex.py would be the preferred place.
There was a problem hiding this comment.
I checked https://github.com/python/cpython/blob/main/Lib/test/test_cmath.py and the tests aren't there so I just removed them. I now understand what you mean, should be all set!
|
@DimitrisJim @youknowone I merged upstream, do you want me to rebase and force push? I usually just squash merge but I can do that as well. |
|
rebase is always preferred but this patch doesn't need commit history, so squash is also ok. Then please check the test part. Then everything will be perfect! |
|
@youknowone Awesome, sounds good. Will do! |
|
run fmt please (check the failed CI job) |
|
@youknowone Sorry just noticed and ran it |
This adds the
sinhandcoshmethods for complex numbers. Adds two more to #3039