Skip to content

Remove not very useful iterator utilty functions #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 4, 2021

Conversation

youknowone
Copy link
Member

based on #3183

@youknowone youknowone marked this pull request as draft October 2, 2021 18:09
@youknowone youknowone marked this pull request as ready for review October 2, 2021 20:11
@youknowone youknowone requested a review from DimitrisJim October 3, 2021 18:27
@DimitrisJim
Copy link
Member

Right, was going to ask, does this supersede #3183 or are you still planning on merging that too?

@youknowone
Copy link
Member Author

either way ok by review convenience

Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me, quick timings show me there's also a slight performance gain too.

@youknowone youknowone merged commit bbbdaf3 into RustPython:main Oct 4, 2021
@youknowone youknowone deleted the pyiter-more branch October 4, 2021 07:19
@youknowone
Copy link
Member Author

yes, though it is just a little bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants