Fix windows ssl #3210
Merged
Fix windows ssl #3210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7314a8c to
7ba2187
Compare
youknowone
reviewed
Oct 3, 2021
| @@ -992,6 +1021,33 @@ fn convert_ssl_error( | |||
| vm.new_exception_msg(cls, msg.to_owned()) | |||
| } | |||
|
|
|||
| fn x509_stack_from_der(der: &[u8]) -> Result<Vec<X509>, ErrorStack> { | |||
| unsafe { | |||
| openssl::init(); | |||
There was a problem hiding this comment.
does openssl::init() is designed to be called whenever this function is called?
There was a problem hiding this comment.
Most of rust-openssl's functions call init() at the start of the function, e.g. X509::stack_from_pem's first line calls it, since it's invalid to use the openssl api without calling it. Obviously we wouldn't get to the point since we call it in make_module but I figured since it's a more generic function it would be good to follow their convention.
youknowone
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.