Big overhaul part 1 - replace PyRc with manual RefCount + WeakRefList #3386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll get to this tonight if someone else doesn't beat me to the punch, but |
bfe7aff to
37e1394
Compare
|
@fanninpm ooh yea, I noticed that myself, that's really old lol. |
7cf10e3 to
69f5c80
Compare
|
At this point, running Miri without |
|
Well, that's probably to be expected, since we don't implement cycle collection and especially type_type and object_type are codependent on each other |
d41f3e0 to
e498933
Compare
youknowone
reviewed
Nov 6, 2021
05b3a28 to
ed289f7
Compare
|
...ok what |
|
what is that error |
|
did an exception cross an ffi boundary in rustc?? |
|
Ok phew, just rerunning ci seemed to have fixed it. |
youknowone
approved these changes
Nov 15, 2021
The outer struct is only 1 word now, and inside the box it's a byte for the mutex (which gets padded to a word) + a word for the linked list (we don't use the tail) + a word for the pointer to the object.
This makes debuggers (or rust-gdb, at least) more pleasant to use, since you don't have to manually cast `PyRef<T>.obj.ptr as `*const PyObjectView<T>` Also get rid of PyGenericObject, since it's vestigial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #2382, resolves #2381 (afaict), and at the very least it will make it much easier to fix any UB now that we control the internals of all the data structures we use.