-
Notifications
You must be signed in to change notification settings - Fork 1.3k
refactor: add a repr helper function for the collections #3471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Those changes are really good ideas. I'll do that. |
0cef857
to
28a11bc
Compare
I have no idea yet. But becasue it failed again exceeding the time limit, it seems this changes made something. |
Try running the following command:
|
28a11bc
to
db8ce84
Compare
db8ce84
to
b11b165
Compare
It was hanging in the snippets. To diagnose,
|
how far are we from completion here @TeamTamoad ? :) |
b11b165
to
0f4d6cd
Compare
Sorry for an late update. I'm super busy with life and college right now. # Test that calling an evil __repr__ can't hang deque
class BadRepr:
def __repr__(self):
self.d.pop()
return ''
b = BadRepr()
d = deque([1, b, 2])
b.d = d
repr(d) It should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thank you for the long time effort!
Implement an helper functions to for repr function of the collections including list, tuple, set and deque.