Skip to content

feat(Lib): print the disassembled info #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2021
Merged

feat(Lib): print the disassembled info #3473

merged 1 commit into from
Nov 28, 2021

Conversation

tai271828
Copy link
Contributor

This pull resolves Issue: #2889

Steps to Test This Pull Request

$ target/debug/rustpython -m dis ./demo.py

                 0 LoadNameAny          (0, print)
                 1 LoadConst            ("Hello, RustPython!")
                 2 CallFunctionPositional (1)
                 3 Pop
                 4 LoadConst            (None)
                 5 ReturnValue

@tai271828
Copy link
Contributor Author

Maybe also related to issue #367

youknowone
youknowone approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for contributing!

@youknowone youknowone self-requested a review November 28, 2021 11:13
youknowone
youknowone previously requested changes Nov 28, 2021
View reviewed changes
@tai271828 tai271828 requested a review from youknowone November 28, 2021 14:24
coolreader18
coolreader18 reviewed Nov 28, 2021
View reviewed changes
@tai271828
Copy link
Contributor Author

Thanks @coolreader18 's review. Re-based and re-submitted. This pull request is ready to review again.

coolreader18
coolreader18 approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for contributing!

@coolreader18 coolreader18 merged commit 00155ab into RustPython:main Nov 28, 2021
@tai271828 tai271828 deleted the pr-issue-2889-dis branch November 28, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

@youknowone youknowone Awaiting requested review from youknowone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tai271828 @youknowone @coolreader18