Skip to content

Add count.reduce() #3737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from May 22, 2022
Merged

Add count.reduce() #3737

merged 4 commits into from May 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 22, 2022

ref #3611

@youknowone
Copy link
Member

are there related tests in test_itertools.py?

@fanninpm
Copy link
Contributor

are there related tests in test_itertools.py?

test_count() has a pickle-related section.

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not compatible to pickle

@@ -303,6 +312,7 @@ mod decl {
Ok(*times.read())
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -193,7 +193,16 @@ mod decl {
}

#[pyimpl(with(IterNext, Constructor))]
impl PyItertoolsCount {}
impl PyItertoolsCount {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for contributing!

@youknowone youknowone merged commit a019cbf into RustPython:main May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants